Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for blockGap between each column in Columns blocks #34453

Closed
richtabor opened this issue Sep 1, 2021 · 0 comments · Fixed by #34456
Closed

Add support for blockGap between each column in Columns blocks #34453

richtabor opened this issue Sep 1, 2021 · 0 comments · Fixed by #34456
Assignees
@richtabor
Labels
[Block] Columns Affects the Columns Block

Comments

@richtabor
Copy link
Member

What problem does this address?

With the new addition of blockGap support to theme.json, we should update the Columns block to reference that gap value — instead of a hard-coded value of 2em.

What is your proposed solution?

Updating the styles to use the generated CSS property var(--wp--style--block-gap) instead of the hard-coded value of 2em, while still providing a fallback to themes that do not have the variable.

Originally called out in #34347.
@richtabor richtabor added the [Block] Columns Affects the Columns Block label Sep 1, 2021
@richtabor richtabor self-assigned this Sep 1, 2021
@richtabor richtabor mentioned this issue Sep 1, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richtabor richtabor

Labels
[Block] Columns Affects the Columns Block
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use blockGap between Columns blocks WordPress/gutenberg
1 participant
@richtabor