-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Output when theme.json is empty #34205
Comments
These default presets are available even if you disable the editor control for the color font size. |
A theme is chosen with styles linked to it. If a user changes a theme, why would you allow the styles to not change? Does that mean every theme requires a default set of styles? If so, where is this list? |
I don't have the link to the original PR where this change was discussed and made, but you can search for it. It explains it better than I can. You can follow the current discussion about naming color properties here: |
I'm still not following, if my theme doesn't use custom properties, why are we shipping every HTML page with these unused CSS variables? It's adding unnecessary page weight which is set at a theme level. |
There's another issue about this at #24684 (comment) |
duplicate of #24684 |
Description
Seeing this when my theme.json is set at:
Step-by-step reproduction instructions
Set theme.json to:
Then view source of a page.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Pre-checks
The text was updated successfully, but these errors were encountered: