Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link Block: Improve link management experience #30908

Closed
priethor opened this issue Apr 16, 2021 · 1 comment
Closed

Navigation Link Block: Improve link management experience #30908

priethor opened this issue Apr 16, 2021 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Post Navigation Link Affects the Post Navigation Link Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Needs design efforts.

Comments

@priethor
Copy link
Contributor

priethor commented Apr 16, 2021

What problem does this address?

The navigation link block fully relies on popovers to manage the link settings (destination, target). Moreover, the popup needs to be opened even to see what link destination is.

Apr-15-2021.13-45-59.mp4

What is your proposed solution?

As suggested during the FSE Go/no-go demo, another approach would be to manage the link settings directly in the toolbar, similar to how the Image Block manages the image cropping:

Apr-15-2021.13-45-37.mp4

However, this approach brings accessibility challenges on its own to navigate the toolbar keyboard-only, as seen in #25890.

@priethor priethor added Needs Design Needs design efforts. [Block] Navigation Affects the Navigation Block [a11y] Keyboard & Focus [Block] Post Navigation Link Affects the Post Navigation Link Block labels Apr 16, 2021
@priethor
Copy link
Contributor Author

Closed as duplicate of #23375

@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Post Navigation Link Affects the Post Navigation Link Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

1 participant