Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Add e2e test to make sure Block preview is visible #29073

Closed
ockham opened this issue Feb 17, 2021 · 1 comment · Fixed by #29117
Closed

Inserter: Add e2e test to make sure Block preview is visible #29073

ockham opened this issue Feb 17, 2021 · 1 comment · Fixed by #29117
Assignees
@ockham @WunderBart
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] E2E Tests /packages/e2e-tests [Status] In Progress Tracking issues with work in progress

Comments

@ockham
Copy link
Contributor

ockham commented Feb 17, 2021

We had a regression in WP 5.6.1 (because #26432 was cherry-picked to the wp/6.5 branch for that patch release, but #26583 wasn't).

We should add an e2e test to make sure block preview is visible when hovering over a block in the inserter (see #28823 for some visuals).
@ockham ockham added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] E2E Tests /packages/e2e-tests labels Feb 17, 2021
@ockham ockham mentioned this issue Feb 17, 2021
Closed
@ockham
Copy link
Contributor Author

ockham commented Feb 18, 2021

Let's maybe work on this one later today during the e2e test hallway hangout.

@ockham ockham mentioned this issue Feb 18, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ockham ockham

@WunderBart WunderBart

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] E2E Tests /packages/e2e-tests [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

E2E Tests: Add basic block preview coverage for inserter WordPress/gutenberg
2 participants
@ockham @WunderBart