Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to absorb font size units #25137

Closed
oandregal opened this issue Sep 8, 2020 · 5 comments
Closed

How to absorb font size units #25137

oandregal opened this issue Sep 8, 2020 · 5 comments
Assignees
@oandregal
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant

Comments

@oandregal
Copy link
Member

Follow-up #24250 (comment)

In developing the Global Styles sidebar, we ran into the issue of having to convert to/from units the font size property. The issue is that font size values are serialized as px values in the post editor, so we did the same for the site editor.

This makes it so the global styles sidebar has to absorb that processing from theme.json data, which was done via utility functions fromPx/toPx.

This is to discuss further steps on how to best manage font-size units. Can we make it so that the UI component is responsible to absorb this complexity?
@oandregal
Copy link
Member Author

cc @ItsJonQ @jorgefilipecosta

@oandregal oandregal added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Decision Needs a decision to be actionable or relevant labels Sep 8, 2020
@oandregal oandregal mentioned this issue Sep 8, 2020
Merged
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Sep 8, 2020
@oandregal
Copy link
Member Author

Related issue #23323

@oandregal oandregal mentioned this issue Sep 17, 2020
Closed
82 tasks
@jorgefilipecosta
Copy link
Member

It seems like we should expand the font size picker to accept values containing units. Being back-compatible when a value is a number it assumes it is a pixel unit value.

@oandregal oandregal mentioned this issue Mar 22, 2021
Merged
7 tasks
@oandregal oandregal mentioned this issue Apr 16, 2021
Merged
7 tasks
@mtias
Copy link
Member

mtias commented Jul 14, 2021

Do we have anything pending here?

@mtias mtias mentioned this issue Jul 15, 2021
Open
65 tasks
@jorgefilipecosta
Copy link
Member

Do we have anything pending here?

I don't think so. I'm going to close the issue.

@apeatling apeatling moved this to Not Started in Design Tools Project Nov 2, 2021
@apeatling apeatling moved this from Not Started to Merged in Design Tools Project Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant
Projects
Design Tools Project
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @oandregal @jorgefilipecosta