Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation component should not require onClick #24877

Closed
joshuatf opened this issue Aug 27, 2020 · 1 comment
Closed

Navigation component should not require onClick #24877

joshuatf opened this issue Aug 27, 2020 · 1 comment
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items.

Comments

@joshuatf
Copy link
Contributor

Describe the bug
When clicking a menu item with an onClick prop in NavigationMenuItem, an error occurs.

To reproduce
Steps to reproduce the behavior:

  1. Clone and checkout this PR from the wc nav - https://github.com/woocommerce/navigation/pull/63
  2. Click on a menu item.
  3. Note the console error.

Expected behavior
Expected to be able to just use a href for menu items.

Screenshots
Screen Shot 2020-08-27 at 5 34 01 PM
@talldan talldan added the [Feature] Navigation Component A navigational waterfall component for hierarchy of items. label Aug 28, 2020
@Copons
Copy link
Contributor

Copons commented Sep 11, 2020

This doesn't happen with #25057 ✨

@Copons Copons closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@talldan @Copons @joshuatf