Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to override Prettier config when using recommended ESLint ruleset #24589

Closed
aduth opened this issue Aug 16, 2020 · 0 comments · Fixed by #24590
Closed

Not possible to override Prettier config when using recommended ESLint ruleset #24589

aduth opened this issue Aug 16, 2020 · 0 comments · Fixed by #24590
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Tool] ESLint plugin /packages/eslint-plugin [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Aug 16, 2020

Previously: #20509, #21602

Steps to Reproduce:

  1. Create a custom .prettierrc with own configuration values that differ from WordPress default (e.g. "printWidth": 100).
  2. Extend @wordpress/eslint-plugin recommended configuration in ESLint
    • { "extends": "plugin:@wordpress/eslint-plugin/recommended" }
  3. Run ESLint

Expected: My Prettier configuration values take precedence.
Actual: The WordPress default config values are always used.

The intention of #20509 is clear in its title that the default should take effect "when no config found". If a configuration is found, it should either be used verbatim, or merged with the WordPress default values.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Tool] ESLint plugin /packages/eslint-plugin labels Aug 16, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Tool] ESLint plugin /packages/eslint-plugin [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant