Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part E2E test inconsistently failing/passing #24281

Closed
talldan opened this issue Jul 30, 2020 · 10 comments
Closed

Template Part E2E test inconsistently failing/passing #24281

talldan opened this issue Jul 30, 2020 · 10 comments
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@talldan
Copy link
Contributor

talldan commented Jul 30, 2020

Describe the bug
I've noticed this test failing sporadically on CI jobs:

FAIL packages/e2e-tests/specs/experiments/template-part.test.js (49.087s)
  ● Template Part › Template part block › Should load customizations when in a template even if only the slug and theme attributes are set.

    TimeoutError: waiting for XPath "//button[contains(text(), "header")]" failed: timeout 30000ms exceeded

      46 | 				'.components-dropdown-menu__toggle[aria-label="Switch Template"]'
      47 | 			);
    > 48 | 			const switchToHeaderTemplatePartButton = await page.waitForXPath(
         | 			                                                    ^

Would be great to figure out what the issue is and fix the test.

@talldan talldan added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jul 30, 2020
@youknowriad
Copy link
Contributor

cc @noahtallen @Addison-Stavlo

@noahtallen
Copy link
Member

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Aug 10, 2020

This is interesting. I can't seem to reproduce it locally, even with various settings like limited network, cpu throttle, slowmo, etc. 🤔

I think @ockham and I saw this fail in CI when we were removing some initial state for edit-site, but iirc couldn't repro locally then either and it seemed to clear up in CI at the time. 🤷‍♀️

I wonder if @epiqueras has any ideas here as the original author for the test, but it does seem a bit strange.

@epiqueras
Copy link
Contributor

The template part is not loading fast enough for some reason. What happens if you increase the timeout?

@noahtallen
Copy link
Member

I'll open a PR for that

@noahtallen
Copy link
Member

🤔 The timeout is: timeout 30000ms exceeded w.r.t finding the text "header" in the dropdown. Thing is, if I try this locally, it should be loading within 2 seconds. I feel it might not be this timeout.. Maybe the dropdown is not opening correctly?

@noahtallen
Copy link
Member

has anyone noticed this recently?

@youknowriad
Copy link
Contributor

It's been sometimes I haven't seen this particular test fail personally.

@youknowriad
Copy link
Contributor

Actually, I just had this again.

@talldan
Copy link
Contributor Author

talldan commented Mar 30, 2021

Haven't seen this fail for a while, so closing.

@talldan talldan closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

No branches or pull requests

5 participants