Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Menu inserter close transition #24060

Open
dratwas opened this issue Jul 20, 2020 · 2 comments
Open

[RNMobile] Menu inserter close transition #24060

dratwas opened this issue Jul 20, 2020 · 2 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.

Comments

@dratwas
Copy link
Contributor

dratwas commented Jul 20, 2020

Describe the bug
When dismissing the inserter bottom sheet, there is no smooth transition — the sheet closes instantly.

To reproduce

  1. Open inserter menu
  2. click on the overlay to dismiss the bottom-sheet
  3. the sheet closes instantly

Expected behavior
There should be a smooth transition instead.

Screenshots
inserterouttransitionissue
@dratwas dratwas added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 20, 2020
@dratwas dratwas mentioned this issue Jul 20, 2020
Merged
3 tasks
@pinarol
Copy link
Contributor

pinarol commented Aug 7, 2020

Text alignment sheet has the same problem.

@dratwas
Copy link
Contributor Author

dratwas commented Aug 7, 2020

This could be helpful with solving that issue wordpress-mobile/WordPress-iOS#14474 (comment)

@jd-alexander jd-alexander mentioned this issue Sep 8, 2020
Closed
6 tasks
@lukewalczak lukewalczak self-assigned this Dec 9, 2020
@lukewalczak lukewalczak mentioned this issue Dec 9, 2020
Closed
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 9, 2020
@lukewalczak lukewalczak removed their assignment Feb 24, 2021
@lukewalczak lukewalczak removed the [Status] In Progress Tracking issues with work in progress label Feb 24, 2021
@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RNMobile] Correct inserter animation WordPress/gutenberg
4 participants
@jordesign @pinarol @dratwas @lukewalczak