-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation block: Add a way to control spacing #23294
Comments
This issue has been discussed on Slack in the weekly Navigation Sync meeting. The resolution was Recently, the cover block has had padding controls (spacing) added. Should we reuse that for the navigation block? |
I think the same controls should be used. Ideally all padding and margin controls are universal. |
Howdy @shaunandrews, I will remove this from the Navigation project as it is not a requirement of the editor. |
Adding the line-height control would definitely help achieve many design patterns like the ones listed in the opening post in a more friendly way than adding vertical spacer controls before and after the navigation block. I think it's something worth adding. |
With the new space-between option, and the incoming updates to the spacer block (#29133) I think we're pretty close to resolving this issue. |
Since #29133 is merged, I'm closing this one. Please reopen, or open a new issue, if an aspect was missing. |
Site headers and footers often require tight control over spacing (typically a combination of padding, margin, and line-height) to achieve the desired look. Ideally, we'd have some way of controlling both vertical and horizontal spacing.
Vertical Spacing
Vertical spacing comes into play in many popular header design patterns, where navigation is displayed on the same line as site title and /or tagline:
Horizontal spacing
Control over spacing between nav menu items is an important aspect of a site header design. It would enable us to create designs like these (hat tip to @iamtakashi for these):
The text was updated successfully, but these errors were encountered: