Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Navigation screen ] Let's have only one loading indicator #23267

Closed
draganescu opened this issue Jun 18, 2020 · 2 comments
Closed

[ Navigation screen ] Let's have only one loading indicator #23267

draganescu opened this issue Jun 18, 2020 · 2 comments
Labels
Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

draganescu commented Jun 18, 2020

Incoming after #23033 will land we'll have two spinners that show up:

  • one spinner for loading the list of available menus
  • one spinner for loading the menu items in the selected menu

Ideally we'd only want one spinner, as multiple loading indicators tend to crowd the visual information highway :)

The idea, discussed with @adamziel is to wrap the page in another component which would know if any of it's children still is in a loading state.

Another option is to have one of those nice loading states where we have a skeleton of gray boxes until we can actually build the page. But this pattern should exist elsewhere as well I'd think.

@adamziel
Copy link
Contributor

I'll spin a proposal PR once #23033 lands to show what I think would be the cleanest solution here - a picture says a thousand words :-)

@talldan talldan added the Needs Design Needs design efforts. label Jan 29, 2021
@shaunandrews
Copy link
Contributor

With the newly updated navigation screen, we now have a single spinner:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants