Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is an Overlay Opacity and not a Background Opacity #23056

Closed
La-Geek opened this issue Jun 10, 2020 · 3 comments · Fixed by #23287
Closed

It is an Overlay Opacity and not a Background Opacity #23056

La-Geek opened this issue Jun 10, 2020 · 3 comments · Fixed by #23287
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance

Comments

@La-Geek
Copy link

La-Geek commented Jun 10, 2020

Imo the term of this is not correct. Not the opacity of the background is changed. The opacity of the overlay is changed, so this is not background opacity. It is overlay opacity.

overlay_opacity
@richtabor
Copy link
Member

Good point, I suggest we change this to "Overlay opacity". Is there any reason not to?

@richtabor richtabor added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Copy Issues or PRs that need copy editing assistance Needs Design Feedback Needs general design feedback. labels Jun 10, 2020
@talldan talldan added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts Needs Copy Review Needs review of user-facing copy (language, phrasing) and removed Needs Design Feedback Needs general design feedback. labels Jun 15, 2020
@talldan
Copy link
Contributor

talldan commented Jun 15, 2020

It was probably intended to refer to the background of the overlay, but if that was the case I do think the distinction isn't needed and is confusing.

My feeling is that the setting is already in the 'Overlay' panel, the label could be changed to just 'Opacity'.

@michelleweber
Copy link

For copy, +1 to simply "Opacity."

@bartczyz bartczyz mentioned this issue Jun 18, 2020
Merged
6 tasks
@ZebulanStanphill ZebulanStanphill removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover block - update copy for Opacity label bartczyz/gutenberg
5 participants
@talldan @La-Geek @richtabor @michelleweber @ZebulanStanphill