Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing View Post from Admin Bar AFTER Publish (not update) #20309

Closed
paaljoachim opened this issue Feb 19, 2020 · 14 comments
Closed

Missing View Post from Admin Bar AFTER Publish (not update) #20309

paaljoachim opened this issue Feb 19, 2020 · 14 comments
Labels
Needs Technical Feedback Needs testing from a developer perspective. [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 19, 2020

(Title and content edited 7th April 2022.)

Local test site in Desktop Server.
Running WP 5.9.3
Twenty Twenty-Two
Chrome

View Post not seen in the top admin bar after publish.

Create a new post/page.
Click Publish.
Notice there is no View Post link in the top admin toolbar.

A View Post link is seen at the end of the Publish panel.
A View Post snackbar is seen (for a few moments).
No top admin toolbar View Post link.

Screenshot 2022-04-07 at 09 01 34

Exiting the post/page and returning to edit View Post is seen in the top admin toolbar.

Screenshot 2022-04-07 at 09 02 29

@talldan
Copy link
Contributor

talldan commented Feb 19, 2020

@paaljoachim Not sure I follow completely. Is this an issue with the ExactMetrics plugin? I'd recommend writing some Steps for Reproduction.

The black top bar isn't part of the block editor, so I think either way this issue doesn't belong here in the Gutenberg repo. It should either be moved to core trac (https://core.trac.wordpress.org/) or you should let the plugin dev know.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Feb 19, 2020

Hey Dan @talldan

Your correct on both accounts. Thanks for your reply...:)
Closing this issue.

@sabernhardt
Copy link
Contributor

This is on Trac now: https://core.trac.wordpress.org/ticket/53948

If we implement the first option, hiding the link until publish/save action, how could the editor remove the hidden class to show the link?

(Or if you think showing the link even before the URL resolves is acceptable, please comment about that on the ticket.)

@audrasjb
Copy link
Contributor

audrasjb commented Apr 6, 2022

Reopening the issue as a related ticket still exists on Trac.

@audrasjb audrasjb reopened this Apr 6, 2022
@ndiego
Copy link
Member

ndiego commented Apr 6, 2022

@audrasjb I was just catching up on the discussion in core Slack. I know the Trac ticket is on the 6.0 milestone, and it seems like the actual fix needs to take place in Gutenberg first. I will add this to the 6.0 Project Board for discussion.

@ndiego ndiego added Needs Testing Needs further testing to be confirmed. Needs Technical Feedback Needs testing from a developer perspective. labels Apr 6, 2022
@talldan
Copy link
Contributor

talldan commented Apr 7, 2022

Could we update the issue title and description to use the proper format for bug reports and be clearer about the actual problem (@paaljoachim, it looks like you made this, so it'd be appreciated if you could revisit it)? Maybe borrow some of the details from trac.

I find this really report hard to follow because it sounds like a plugin issue. It's not great to force every person that reads it to also have to read all the comments in the issue as well as the trac ticket and comments there too.

@paaljoachim paaljoachim changed the title View post/page link-button is hidden Missing View Post from Admin Bar AFTER Publish (not update) Apr 7, 2022
@paaljoachim
Copy link
Contributor Author

I retested and the title and content is edited.

@paaljoachim paaljoachim added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Apr 7, 2022
@talldan
Copy link
Contributor

talldan commented Apr 7, 2022

Thanks!

@Mamaduka
Copy link
Member

Mamaduka commented Apr 7, 2022

I don't think we can fix this in Gutenberg. Admin bar menu item would require a full page refresh to render.

@ndiego
Copy link
Member

ndiego commented Apr 7, 2022

From a purely personal perspective, I think this is an acceptable "bug" to simply ignore. When you go through the publish flow, there are many links that a user can click on the "View Page/Post". I also work in Fullscreen Mode and never see the admin bar so that might be influencing my thoughts here. 😬

@sabernhardt
Copy link
Contributor

This is probably more enhancement than bug, but I kept the type as reported due to the lack of parity with the Classic Editor. Using Classic, the View Post link has been available in the admin toolbar immediately after publishing/saving because it refreshes the page and switches from New Post to the Edit Post screen.

If the link is added in the admin toolbar for the New Post screen (on the Trac ticket), I would need help with the editor side. The editor would need to check whether the link exists and then remove the hidden class when saving the post.

If it needs to wait until next release, I could update the since note to 6.1.0 instead of 6.0.0.

@talldan
Copy link
Contributor

talldan commented Apr 8, 2022

I think it could be possible, but it would probably require a bit of work in core. Gutenberg could use a react portal to the admin bar to render a component there.

It would require a couple of things:

  • An HTML element to use for the portal
  • The existing View Post link to be inactive when the block editor is used.

Like others mention, I don't know whether it's worth it. This bug is likely to have been present since 5.0, and it's only being reported now.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 8, 2022

We adapt to what is present and find work arounds.

Anyhow it might need a bigger resolution through design.
Linking in associated issues.

Make Permalink/View Post easier to access
#30579

Site Editor - 'Preview Site' feature. (Linked to my comment there)
#29398 (comment)

@annezazu
Copy link
Contributor

Closing this out as it hasn't gained much traction with additional reports in the two years since and since we have a "view post" option after publishing:

view.post.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Technical Feedback Needs testing from a developer perspective. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants