Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Block Inserter search sometimes doesn't work in IE11 #19142

Closed
gwwar opened this issue Dec 13, 2019 · 2 comments
Closed

Keyboard Block Inserter search sometimes doesn't work in IE11 #19142

gwwar opened this issue Dec 13, 2019 · 2 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@gwwar
Copy link
Contributor

gwwar commented Dec 13, 2019

Describe the bug
Sometimes an error is thrown when typing / into the block editor to initiate a block insertion using the keyboard with IE11

Screen Shot 2019-12-13 at 2 43 26 PM

Screen Shot 2019-12-13 at 2 42 59 PM

Should be fixed by the added guard in #14815 though the PR did not make it into the 7.1.0 release

To reproduce
Steps to reproduce the behavior:

  1. Load Gutenberg in IE11
  2. Type / and some letters
  3. JS error is thrown, block inserter does not appear

Expected behavior
Block search results should display

Additional context

  • IE11, Gutenberg plugin 7.1.0
@gwwar gwwar added the [Type] Bug An existing feature does not function as intended label Dec 13, 2019
@skorasaurus skorasaurus added Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. labels Dec 27, 2020
@paaljoachim
Copy link
Contributor

Hey @gwwar Kerry

Is this issue still valid?

@gwwar
Copy link
Contributor Author

gwwar commented Mar 25, 2021

Forgot to close this one out

@gwwar gwwar closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skorasaurus @gwwar @paaljoachim