Consider hover indictation radius in toolbar

[karmatosed]

The hover on the toolbar has a radius:

You can see it clearly here:

If the border-radius is removed it looks like this, which feels more fitting for now:

It's worth noting this uses a shadow to get hover effect and seems related to a component, so a PR might need some deeper digging.

[shaunandrews]

I don't think removing the border-radius is the right solution. That radius is applied to all buttons and icon-buttons throughout the editor, including in the top toolbar. I think the better solution might be to add 2px of space around the icon-buttons in the toolbar, bumping up the size of the toolbar to 40px.

Here's the current (36px) space, vs the proposed (40px) space:

[phpbits]

I don't think removing the border-radius is the right solution. That radius is applied to all buttons and icon-buttons throughout the editor, including in the top toolbar. I think the better solution might be to add 2px of space around the icon-buttons in the toolbar, bumping up the size of the toolbar to 40px.

+1, adding margin will make it look better. Here's what I'm using on EditorsKit plugin for toolbar button with text content :

[karmatosed]

Marking as good first issue as making a PR to add margin could be a good starting place.

[Addison-Stavlo]

I have opened a PR (noted above) that does as @shaunandrews suggested.

I have a question there (with screenshots) regarding weather or not we also want this margin on the block-mover part of the toolbar as well.