Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using font-relative widths and heights in containing elements #16181

Closed
anevins12 opened this issue Jun 14, 2019 · 2 comments
Closed
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@anevins12
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When structural elements contain text, we should consider setting their widths or heights in a way that responds to text size increase (not talking about zoom here).

This came about when looking at the resolution for #15973 . This is fine, but the sidebar is still very cramped with the increase of font size. It could do with being larger.

Describe the solution you'd like
Using em on the container's width or height values so that when text size increases, the containers also increase.

We can start this approach on the sidebar discussed in 15973.

Describe alternatives you've considered
I think can use CSS 'max-width' to define a PX constraint to meet the design, and instead use CSS 'width' as the relative measurement:
.foo { max-width: something-reasonable-px; width: 100em }

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Jun 17, 2019
@draganescu draganescu added the CSS Styling Related to editor and front end styles, CSS-specific issues. label Apr 22, 2020
@paaljoachim
Copy link
Contributor

@aristath and @ItsJonQ
Is this issue still relevant?

@aristath
Copy link
Member

Is this issue still relevant?

I don't think so, all block styles now use em values and not px, with just a few exceptions that don't have anything to do with this ticket.
I'll go ahead and close this issue, if however I am mistaken please feel free to post some clarifications and we can reopen it for further discussion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants