Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings block a11y warning #15425

Closed
hearvox opened this issue May 3, 2019 · 4 comments
Closed

Headings block a11y warning #15425

hearvox opened this issue May 3, 2019 · 4 comments
Labels
[Block] Heading Affects the Headings Block [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@hearvox
Copy link

hearvox commented May 3, 2019

Perhaps the Headings block could warn users about to enter an improper heading level, e.g., an h4 after an h2. Might it be possible for block to be aware of the current Document Outline output and where, within it, user is currently entering the heading?

@swissspidy
Copy link
Member

Those warnings are currently present in the Document Outline:

Screenshot 2019-05-04 at 12 19 03

So you are suggesting to add these warnings to the heading block too, correct?

@swissspidy swissspidy added [Block] Heading Affects the Headings Block [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page labels May 4, 2019
@hearvox
Copy link
Author

hearvox commented May 4, 2019

Wow, had no idea about the headings warnings in Document Outline. Great feature. But, yes, I am suggesting a warning also appear in the Headings block. A minority of users consult the Document Outline (of those, most already understand heading-levels). A Headings block notice/warning would for the majority of users who don't. It would not only help lead them to a greater understanding of headings hierarchy but also catch and correct maybe-millions more headings-level errors.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 5, 2019
@afercia
Copy link
Contributor

afercia commented May 5, 2019

Related: #10581 which proposes to add a warning in the sidebar. In-progress pull request: #14889. Not sure a warning displayed within the block itself would make the design team happy :) @hearvox do you think a warning in the sidebar would be sufficient?

@hearvox
Copy link
Author

hearvox commented May 5, 2019

@afercia I absolutely think #10581 -- a notice in block sidebar -- is a great solution. Exposing the hierarchy in the headings block Closing this issue and following the related one. thx

@hearvox hearvox closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants