Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Block: Consider graying out indentation buttons when they will have no effect. #13402

Closed
kjellr opened this issue Jan 21, 2019 · 3 comments · Fixed by #17819
Closed

List Block: Consider graying out indentation buttons when they will have no effect. #13402

kjellr opened this issue Jan 21, 2019 · 3 comments · Fixed by #17819
Assignees
@ellatrix
Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Rich text /packages/rich-text [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 21, 2019

When you're editing a list block item that's already positioned all the way to the left, clicking the "Outdent List Item" button has no effect. We should consider graying out the left indent button to show that it's disabled.

artboard
@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] List Affects the List Block labels Jan 21, 2019
@sarahmonster sarahmonster mentioned this issue Jan 21, 2019
Closed
13 tasks
@ellatrix
Copy link
Member

ellatrix commented Feb 8, 2019

I agree.

@ellatrix ellatrix added the [Package] Rich text /packages/rich-text label Feb 8, 2019
@sarahmonster
Copy link
Member

💯💯💯

Would this make for a good first issue from a development perspective?

@melchoyce melchoyce added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jun 4, 2019
@melchoyce
Copy link
Contributor

Let's do it!

@mapk mapk added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jun 4, 2019
@ellatrix ellatrix mentioned this issue Jun 4, 2019
Closed
17 tasks
@ellatrix ellatrix mentioned this issue Oct 7, 2019
Merged
5 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 7, 2019
@gziolo gziolo removed the Needs Dev Ready for, and needs developer efforts label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Rich text /packages/rich-text [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

List Block: disable indent/outdent buttons WordPress/gutenberg
6 participants
@sarahmonster @mapk @gziolo @kjellr @melchoyce @ellatrix