-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial on building a "hover reveal" pattern #215
Comments
Just wanted to say that I think this will be super useful. 🚀 |
I'm going to chip away at this in the coming weeks. Expect progress reports. 🕺 |
I had a pretty solid demo on my local, but then logged in today and saw there were WP Updates, including three default themes. So, I updated and then I realized I had my custom CSS in the TT4's |
Never mind - I think I've managed to get some of it back. Crisis averted thanks to VS Code's Timeline view |
Here are general outline for post:
cards-demo.mp4 |
Overall, this looks like a good plan of action, @colorful-tones. The one thing I'd suggest is using a block stylesheet over PHP for the CSS, which I feel like would be more realistic for real projects where you'd want syntax highlighting in your code editor: https://developer.wordpress.org/themes/features/block-stylesheets/ I wasn't sure if that was the direction you were going or just using PHP to quickly show the example code via Gist. |
This is ready for a first review. |
Hey @colorful-tones, what a great tutorial! I'm gonna use this pattern the first chance I get :-) I tested the code, and made what looks like a lot of suggestions, though it's mostly shifting things around. Hope it all makes sense. Let me know if you have any questions. First review done 🥳 |
@ironnysh thanks for the very thorough review. I've applied most of your feedback. However, there are a few items I left open for discussion. Would you mind taking a peak at the remaining items please, and let me know if we're good to move forward to 2nd draft or if you desire further collaboration? the draft |
@bph this is ready for a 2nd review. One thing I wanted to point out is that it might be good to consider having a code-style guide for writers/contributors to the Dev Blog. CSS nesting came up, and @ironnysh and I had a good discussion about whether we should nest our CSS examples. I also did some outreach on Twitter/X and a few different Slack spaces, and it seems clear that nesting CSS code examples have more potential for misleading and perhaps encouraging poor practices, and we should likely refrain from doing so in tutorials. |
My pleasure, @colorful-tones! 💫 @bph, I thought we might add it to the next editorial meeting agenda, see how people feel about it. |
I am done with the 2nd review with minimal comments. It's a great tutorial. Thank you, Damon. |
@colorful-tones Once you are through with the feedback on the reviews, here are the checklists. As a member of the repo, you should be able to check each line item off. Pre-publishing checklist: (updated 1/29/2024)
Post-publishing checklist
|
Copy for social post:
|
This is ready for pre-publish preview: https://developer.wordpress.org/news/?p=3934&preview=1&_ppp=0018834fc2 |
Final published resource: https://developer.wordpress.org/news/2024/07/30/building-a-card-layout-with-a-hover-reveal-effect/ |
Social schedule on Tue, Aug 13, 2024 |
Discussed in #203
Originally posted by justintadlock January 11, 2024
There's been a lot of discussion around building a specific layout with the block editor. Specifically, something like this (shown in a hover card style):
This is a pretty popular web design pattern, and it'd be great to show how it's possible with the block editor and can be shipped in a theme as a pattern.
Some of the community discussion and responses:
Responses to my tweet (last link above) have been overwhelmingly positive and ask for a tutorial. Thus, this proposal.
The Proposal
Write a tutorial that covers a lot of ground that is geared toward theme creators. This would be:
The Code
I've done some preliminary code work and am just backing it up here. Note: some of the below will have classes and such from my personal theme, so it'll need to be translated to TT4.
assets/css/blocks/core/columns.scss
:assets/css/blocks/core/cover.scss
:patterns/hero-cards.php
:The text was updated successfully, but these errors were encountered: