From 998ee235d4823254f6e98977983fc5dbf050361d Mon Sep 17 00:00:00 2001 From: Joen Asmussen Date: Tue, 6 Jun 2017 09:36:11 +0200 Subject: [PATCH 1/2] Add aria-hidden and role attributes to react component This addresses an accessibility issue with the react component, by adding attributes aria-hidden="true" and role="img" to the component. See also discussion in https://github.com/WordPress/gutenberg/pull/1012#pullrequestreview-42141408. --- react/dashicon/inc/index-footer.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react/dashicon/inc/index-footer.jsx b/react/dashicon/inc/index-footer.jsx index 5522a28d..91eb1210 100644 --- a/react/dashicon/inc/index-footer.jsx +++ b/react/dashicon/inc/index-footer.jsx @@ -7,7 +7,7 @@ const iconClass = [ 'dashicon', 'dashicons-' + icon, className ].filter( Boolean ).join( ' ' ); return ( - + ); From 17adf0cc07acbceb7f954b8cf10b8d2daea52476 Mon Sep 17 00:00:00 2001 From: Joen Asmussen Date: Tue, 6 Jun 2017 09:38:34 +0200 Subject: [PATCH 2/2] Fix typo. --- react/dashicon/inc/index-footer.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react/dashicon/inc/index-footer.jsx b/react/dashicon/inc/index-footer.jsx index 91eb1210..d01f87d5 100644 --- a/react/dashicon/inc/index-footer.jsx +++ b/react/dashicon/inc/index-footer.jsx @@ -7,7 +7,7 @@ const iconClass = [ 'dashicon', 'dashicons-' + icon, className ].filter( Boolean ).join( ' ' ); return ( - + );