Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with $temp_file sometimes not being a string #360

Closed
mikachan opened this issue May 10, 2023 · 1 comment
Closed

Error with $temp_file sometimes not being a string #360

mikachan opened this issue May 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mikachan
Copy link
Member

It looks like $temp_file in class-manage-fonts.php can sometimes not be a string, so we should improve how this is handled. I've noticed this error when using the plugin in a WordPress Playground environment.

image

To reproduce:

  1. Spin up a WordPress Playground instance with the plugin installed (example)
  2. Go to Appearance -> Manage Theme Fonts -> Add Google font button
  3. Select a Google font from the dropdown menu
  4. Select a font variant from the list of fonts
  5. Click the 'Add Google fonts to your theme' button
  6. You should see the above error

Originally discussed here: WordPress/wordpress-playground#276
@mikachan mikachan added the bug Something isn't working label May 10, 2023
@mikachan mikachan mentioned this issue May 10, 2023
Closed
@pbking
Copy link
Contributor

pbking commented Apr 29, 2024

a font-related bug that is no longer relevant. closing.

@pbking pbking closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbking @mikachan