Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Admin Settings - Default upload file types & broken link #240

Open
WRasada opened this issue May 31, 2023 · 1 comment
Open

Network Admin Settings - Default upload file types & broken link #240

WRasada opened this issue May 31, 2023 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@WRasada
Copy link

WRasada commented May 31, 2023

Issue Description

The default upload file types are incorrect and there is a formatting issue and broken link.

URL of the Page with the Issue

https://wordpress.org/documentation/article/network-admin-settings-screen/#upload-file-types

Section of Page with the issue

Upload file types

Why is this a problem?

The default list is different than what the schema sets: https://github.com/WordPress/WordPress/blob/37e599fb3ebe4452009cc598fd8783261b7e3b3b/wp-admin/includes/schema.php#L1243-L1281

This generates a default list that comes out to:

jpg jpeg png gif webp mov avi mpg 3gp 3g2 midi mid pdf doc ppt odt pptx docx pps ppsx xls xlsx key mp3 ogg flac m4a wav mp4 m4v webm ogv flv

The notable difference is that this does not contain wmv or m2ts as the documentation currently states and m2ts is not a supported mime type in get_mime_types(): https://github.com/WordPress/wordpress-develop/blob/6.2/src/wp-includes/functions.php#L3328-L3448

Also, the wp-includes/functions.php link is broken and there is a formatting issue with theupload_mimesfilter!:

Suggested Fix

Update the default list to:

jpg jpeg png gif webp mov avi mpg 3gp 3g2 midi mid pdf doc ppt odt pptx docx pps ppsx xls xlsx key mp3 ogg flac m4a wav mp4 m4v webm ogv flv

Correct the broken wp-includes/functions.php link to point to Repo/Trac.

Fix the spacing around

... theupload_mimesfilter! ...

@zzap
Copy link
Member

zzap commented May 31, 2023

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@stevenlinx stevenlinx transferred this issue from WordPress/Documentation-Issue-Tracker Jun 1, 2023
@javiercasares javiercasares added bug Something isn't working documentation Improvements or additions to documentation labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants