Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Regex search is broken in store version, when using none EN Lang #33

Open
saschanaz opened this issue Nov 2, 2018 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@saschanaz
Copy link

Description of the Issue

Regex search in Control+F window incorrectly cannot find anything.

Steps to Reproduce the Issue

  1. Copy-paste 12가3456
  2. Control+F, check regex mode, type \d{2}[가-힣]\d{4}
  3. Try find a match

Expected Behavior

It should find a match as the original desktop version do.

Actual Behavior

It cannot.

Debug Information

@jakevis
Copy link
Member

jakevis commented Nov 2, 2018

@saschanaz thanks for the report - and I have a repo of this working. None of that relevent code changed when moving it to the store.. so either windows is creating an issue with filtering... or I have pulled some code in from upstream that introduces this bug.

I am also missing some Lang settings I think in the manifest file - so let me go and correct that. Out of interest do you know exactly what encoding that is?

@jakevis jakevis self-assigned this Nov 2, 2018
@jakevis jakevis added the bug Something isn't working label Nov 2, 2018
@jakevis jakevis changed the title Regex search is broken in store version Regex search is broken in store version, when using none EN Lang Nov 2, 2018
@jakevis
Copy link
Member

jakevis commented Nov 2, 2018

Regex is working with en-us... ill need to test some other encodings as well.

@saschanaz
Copy link
Author

saschanaz commented Nov 3, 2018

It doesn't really use any 'encoding' (as Notepad++ probably always uses UTF-8), but anyway it's a Korean character.

@jakevis
Copy link
Member

jakevis commented Nov 5, 2018

@saschanaz the compiled version from AppVeyor (https://ci.appveyor.com/project/jakevis/notepad-plus-plus/build/job/yibyqcjd2a9qevn6/artifacts) works as it should.. this is the exe and dll that is included in the appx. This does mean that something is happening in windows or windows store to break this. The manifest does include a "supported" char set section. Next debugging step is to update that.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants