-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WireMock.Net.xUnit project #759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 72.88% 72.79% -0.09%
==========================================
Files 194 195 +1
Lines 6919 6955 +36
Branches 727 729 +2
==========================================
+ Hits 5043 5063 +20
- Misses 1656 1673 +17
+ Partials 220 219 -1
Continue to review full report at Codecov.
|
using WireMock.Logging; | ||
using Xunit.Abstractions; | ||
|
||
namespace WireMock.Net.xunit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the namespace should be WireMock.Net.Xunit
to follow the same naming as the xUnit project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
I guess folders, assembly names etc. should be renamed to |
Yes, it's a mess. I would say in namespaces and assembly use The all lowercase version is not really used anywhere besides the xUnit assemblies, which is likely of legacy reasons. It's basically caused by the conflict of C# using pascal case but xUnit starting with a lowercase letter which makes it a bit difficult 🙂 |
No description provided.