Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OpenApiPathsMapper to handle Value/Wildcard #691

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Nov 21, 2021

No description provided.

@StefH StefH added the feature label Nov 21, 2021
@StefH StefH self-assigned this Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #691 (d9123ee) into master (8865543) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files         174      174           
  Lines        6224     6224           
  Branches      646      646           
=======================================
  Hits         4643     4643           
  Misses       1375     1375           
  Partials      206      206           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8865543...d9123ee. Read the comment docs.

@StefH
Copy link
Collaborator Author

StefH commented Nov 21, 2021

Hello @JanuszRybinski and @leolplex,

Based on the idea from @JanuszRybinski (#690) I created this PR which handles the same logic, but in a more logical/configurable way.

Can you both please review this PR?

@leolplex
Copy link
Contributor

Hello @StefH,

I checked it and test in my local, it is working really fine. I like this new feature.

Daniel.

@JanuszRybinski
Copy link

Hello,

@leolplex I'm glad you also liked this idea. @StefH I also checked locally, everything is fine in my opinion. I see your fluency in making changes in this code. I am just starting to use this tool, and I hope to get this "flow" in the future :)

Best regards,
Janusz

@StefH StefH merged commit 897ee9f into master Nov 23, 2021
@StefH StefH deleted the stef-openapi-example branch November 23, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants