bug: fix supporting the Patch method and logging the body #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Patch not configured to support Body - Add a unit test
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 52.81% 52.81%
=======================================
Files 66 66
Lines 2378 2378
Branches 329 329
=======================================
Hits 1256 1256
Misses 980 980
Partials 142 142
Continue to review full report at Codecov.
|
StefH
reviewed
Nov 20, 2017
| @@ -91,8 +91,9 @@ private bool ParseBody(string method) | |||
| TRACE - Body not supported. | |||
| OPTIONS - Body supported but no semantics on usage (maybe in the future). | |||
| CONNECT - No defined body semantics | |||
| PATHC - Body suported | |||
StefH
approved these changes
Nov 20, 2017
|
Not sure but don't think this has been released? Could it be please? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you need to mock an API designed to the JsonAPI specification you need to work with PATCH requests with a http body. This fix and tests should allow support of PATCH with body and ensure the correct information gets logged.