Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions for ClientIP, Url and ProxyUrl #529

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Add assertions for ClientIP, Url and ProxyUrl #529

merged 2 commits into from
Nov 10, 2020

Conversation

akamud
Copy link
Contributor

@akamud akamud commented Nov 2, 2020

No description provided.

StefH
StefH requested changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you merge latest master into your branch? There is a problem with sonar scanner

  2. Can you put params object[] becauseArgs on the same line as the method?

@akamud
Copy link
Contributor Author

akamud commented Nov 5, 2020

Hi, don't worry, I will make these changes as soon as I get time this week.

@akamud
Copy link
Contributor Author

akamud commented Nov 8, 2020

Pushed all the requested changes.

@akamud akamud requested a review from StefH November 8, 2020 16:40
@StefH
Copy link
Collaborator

StefH commented Nov 10, 2020

@akamud --> Thanks!

@StefH StefH added the feature label Nov 10, 2020
@StefH StefH merged commit c104b8b into WireMock-Net:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefH StefH StefH approved these changes

@musthafam musthafam musthafam approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akamud @StefH @musthafam