Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Introduced dependency on log4net #94

Closed
alexangas opened this issue Feb 27, 2018 · 2 comments
Closed

Issue: Introduced dependency on log4net #94

alexangas opened this issue Feb 27, 2018 · 2 comments
Assignees

Comments

@alexangas
Copy link
Collaborator

Hello,

It looks like in v1.0.3 a dependency was introduced for log4net. I'm just wondering if it's possible to remove this please, or only include it for the Standalone server?

This doesn't significantly affect my project right now - at worst it is a mild annoyance as we use a different logging framework.

However for a project I worked on a year ago, this dependency would have made it impossible to use WireMock.Net. This is because for some reason, log4net is a candidate for abuse where developers create their own versions and embed it within their projects without changing the namespace. I've seen this twice in my career so far on significant projects such as NServiceBus (an old 2.x version but still in use), and an older version of Sitecore. It makes it impossible to include a reference to the official log4net binary.

Regardless, logging isn't required for the solution to operate, so it would be helpful if it was not included as a required dependency. 😃

Can logging please be exposed as some sort of interface instead so developers can plug in their own logging code? It is simple to write.

Thanks for your consideration!

@StefH StefH changed the title Introduced dependency on log4net Issue: Introduced dependency on log4net Feb 27, 2018
@StefH StefH self-assigned this Feb 27, 2018
@StefH
Copy link
Collaborator

StefH commented Feb 27, 2018

I'll refactor the code to use logging interface which will probably look a lot like log4net or nlog.

@StefH
Copy link
Collaborator

StefH commented Feb 27, 2018

I've created a PR, and I want to add you as a reviewer, and I sent invite request for this repository.

StefH added a commit that referenced this issue Feb 28, 2018
* Replace log4net by custom logger

* WireMockNullLogger
@StefH StefH closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants