Case insensitive and ignoring optional path and header parameters in OpenApiPathsMapper

[JanuszRybinski]

Hello @StefH and @leolplex,

related to (#691) but I decided to start a new discussion. While I testing OpenApi Parser, I encountered an interesting behavior of HttpRequestMessage, I will show on an example.

Assuming I have this definition of request:

  "paths": {
    "/somethinks": {
      "put": {
        "parameters": [
          {
            "name": "X-Correlation-Id",
            "in": "header",
            "required": true,
            "schema": {
              "type": "string"
            }
          }
       ]
     }
  }

And I want to define a request for this:

using (var request = new System.Net.Http.HttpRequestMessage())
{
    request.Headers.TryAddWithoutValidation("X-Correlation-Id", "some value");
}

I did not check why exactly, but a header called "X-Correlation-ID" will be added to the request. By this small difference there is no matching mapping. In my opinion, headers should not be case-sensitive. To be sure, I checked what is in the RFC (https://www.rfc-editor.org/rfc/rfc7230#section-3.2). I have another idea to set case ignore in MapRequestHeaders:

var list = headers
    .Select(qp => new HeaderModel
    {
        Name = qp.Name,
        Matchers = new[]
        {
            GetExampleMatcherModel(qp.Schema, _settings.HeaderPatternToUse)
        },
        IgnoreCase = true
    })
    .ToList();

It seems to me that a similar setting also could be used in MapQueryParameters.

Additionally, I think that only the required parameters and headers should be taken into mappings:

var list = queryParameters
    .Where(qp => qp.Required)

var list = headers
    .Where(h => h.Required)

What is your opinion? If you agree, should I submit a new PR, or it can be added as part of #691?

Regards,
Janusz

[leolplex]

Hello @JanuszRybinski / @StefH ,

It all makes sense to me, I also would add the required parameters in request body.

WireMock.Net/src/WireMock.Net.OpenApiParser/Mappers/OpenApiPathsMapper.cs

Line 64 in 8865543

if (operation.RequestBody != null && operation.RequestBody.Content != null)

if (operation.RequestBody != null && operation.RequestBody.Content != null && operation.RequestBody.Required)

[StefH]

You can create a new PR.