-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for template language DotLiquid #214
Comments
Hi I wish ti help you to implement the feature. |
Currently I support Handlebars.Net as response templating language (https://github.com/WireMock-Net/WireMock.Net/wiki/Response-Templating). However, It would also be a nice option to support DotLiquid as templating engine. |
@StefH is DotLiquid critical? from my point of view it's not stable. There is another library called scriban. What do you think? |
My idea to support DotLiquid was that I think that also Microsoft used this for generating (help) pages. But I see that scriban supports both, so that would be a good solution. However the code from WireMock.Net does not support other transformation engines yet, so that needs to be reworked first. |
@StefH Can you please provide any links about microsoft used DotLiquid? About other transformations engines, what do you mean exactly? And what should be reworked from your perspective? |
|
Scriban does only support .netstandard 2.0 and net5.0 So that's difficult to use in WireMock.Net |
@n1l I've update the code to also support Sciban See this MyGet preview: |
Did you finish the code? I was going to help you, but as I can see you did it alone? :) |
Correct, I think I've the code change in place. However, the syntax from Sciban does differ in some parts from Handlebars.Net , so I could not get all unit tests working. Maybe you can take a look there? |
It would be easier to me to start from the white paper not to fix the code you have written. So probably it's all yours now untill I have time to do it my way :) |
I noticed these differences:
|
Code is merged to maaster and a new NuGet will be released. Further fixes like
Will be maybe taken up in another PR |
No description provided.
The text was updated successfully, but these errors were encountered: