From 30c7791ed22233ed0123be60bf070e756e8ed844 Mon Sep 17 00:00:00 2001 From: Weiqun Zhang Date: Tue, 13 Feb 2024 12:12:32 -0800 Subject: [PATCH] Fix a typo in SYCL version of scan (#3757) This is a small performance issue. With the typo, it always does a memcpy from device to host to get the total sum even when it's told it's not needed. --- Src/Base/AMReX_Scan.H | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/Base/AMReX_Scan.H b/Src/Base/AMReX_Scan.H index 11fdfd8bd70..4ed44c8c749 100644 --- a/Src/Base/AMReX_Scan.H +++ b/Src/Base/AMReX_Scan.H @@ -400,7 +400,7 @@ T PrefixSum (N n, FIN && fin, FOUT && fout, TYPE type, RetSum a_ret_sum = retSum #ifndef AMREX_SYCL_NO_MULTIPASS_SCAN if (nblocks > 1) { - return PrefixSum_mp(n, std::forward(fin), std::forward(fout), type, retSum); + return PrefixSum_mp(n, std::forward(fin), std::forward(fout), type, a_ret_sum); } #endif