From 7d1beae6e0ba7112c90b61a6ac5a2653e6be987b Mon Sep 17 00:00:00 2001 From: Stacy Kvernmo Date: Mon, 20 Mar 2017 07:54:52 -0500 Subject: [PATCH] Typo in desc, and size mixin updates (#253) * fix typo * Remove height if using size mixin Although, this looks like it is going away in version 5. * Only 1 value if they are the same for size mixin If you have 2 of the same values in size mixin, doesn't it compile to height: 100% 100%; width: 100% 100%; http://www.sassmeister.com/gist/38c909c75a0474e6b587b849f2beb800 * dup sizes - I'd amend but I am working in browser * Dup Sizes in commented out code --- assets/sass/base/_accessibility.scss | 3 +-- assets/sass/base/_media.scss | 2 +- assets/sass/modules/_hero.scss | 4 ++-- inc/acf.php | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/assets/sass/base/_accessibility.scss b/assets/sass/base/_accessibility.scss index ff6905126..614e63cf0 100644 --- a/assets/sass/base/_accessibility.scss +++ b/assets/sass/base/_accessibility.scss @@ -4,10 +4,9 @@ // Hide text meant only for screen readers .screen-reader-text { - @include size(rem(1) auto); + @include size(rem(1)); clip: rect(rem(1), rem(1), rem(1), rem(1)); - height: rem(1); overflow: hidden; position: absolute; white-space: nowrap; // do not smuch text in screen readers diff --git a/assets/sass/base/_media.scss b/assets/sass/base/_media.scss index e4d1bdb1c..e27ab8f0a 100644 --- a/assets/sass/base/_media.scss +++ b/assets/sass/base/_media.scss @@ -142,7 +142,7 @@ img { // Video as background .video-as-background { - @include size(100% 100%); + @include size(100%); display: block; object-fit: cover; diff --git a/assets/sass/modules/_hero.scss b/assets/sass/modules/_hero.scss index 350c2d6c6..ee22dd8fc 100644 --- a/assets/sass/modules/_hero.scss +++ b/assets/sass/modules/_hero.scss @@ -13,7 +13,7 @@ // Transparent overlay (optional). &::after { @include position(absolute, 0 0 null null); - @include size(100% 100%); + @include size(100%); background-color: rgba($color-black, 0.6); content: ""; @@ -24,7 +24,7 @@ // &:after { // @include linear-gradient(to bottom, rgba($color-black, 0) 0%, rgba($color-black, 0.50) 50%); // @include position(absolute, 0 0 null null); - // @include size(100% 100%); + // @include size(100%); // content: ''; // z-index: 2; diff --git a/inc/acf.php b/inc/acf.php index f3ef92ec1..5a804a03c 100644 --- a/inc/acf.php +++ b/inc/acf.php @@ -2,7 +2,7 @@ /** * Custom ACF functions. * - * A place to custom funcdtionality related to Advanced Custom Fields. + * A place to custom functionality related to Advanced Custom Fields. * * @package _s */