Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset modification for presence of WP Admin Bar #4

Closed
salcode opened this issue Apr 22, 2015 · 1 comment
Closed

Add offset modification for presence of WP Admin Bar #4

salcode opened this issue Apr 22, 2015 · 1 comment

Comments

@salcode
Copy link
Contributor

salcode commented Apr 22, 2015

The presence or absence of the WP Admin Bar causes a change in the size of the offset necessary.

It seems that ideally this should be handled in the JavaScript, where the presence or absence of the WP Admin Bar is detected and the offset modified.

The question is what does this offset modification look like.

  • Is the option set assumed to be with or without the WP Admin Bar?
  • Does it make sense to include two options (one for with and one for without the WP Admin Bar)?
@jtsternberg
Copy link
Contributor

Agree, offset should be auto-adjusted if the admin bar is visible. The input should be clear that it is asking for the height when the admin bar is not being displayed. I def. don't like the idea of two options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants