Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic in .github/workflows/compile-tests.yml to Makefile #43

Closed
codefromthecrypt opened this issue Jan 15, 2023 · 4 comments
Closed

Comments

@codefromthecrypt
Copy link

codefromthecrypt commented Jan 15, 2023

Right now, the compilation steps are defined outside the scope of the test runner, and executing them is copy/paste from .github/workflows/compile-tests.yml.

What I would love to see instead is:

make install - runs the python install as needed
make compile - compiles all the various things
make test - runs python3 test-runner/wasi_test_runner.py
make default does install, compile, test which prevents out-of-date steps.

Lacking this causes unnecessary glitches. For example, I ran compilation manually earlier and forgot the steps needed. The source of one file changed, though the old binary was present. Specifically, the test changed expectations of exit code 1 to 33.

One the makefile is together, integrators like me can have an easier time, and the GitHub part is simpler as it just calls targets vs very explicit step implementations.

@codefromthecrypt codefromthecrypt changed the title proc_exit on assemblyscript seems to pass the wrong code (1) Move logic in .github/workflows/compile-tests.yml to Makefile Jan 15, 2023
@codefromthecrypt
Copy link
Author

renamed as the issue was about drift

@loganek
Copy link
Collaborator

loganek commented Jan 16, 2023

Hi @codefromthecrypt , I think it makes sense to have build script defined outside of the github workflow. I'm quite interested in your usecase though - runtimes should use precompiled WASM binaries from prod/testsuite-base branch so they won't have to install the toolchain and compile the code by themselves. Is that something that'd work better for you?

@codefromthecrypt
Copy link
Author

@loganek that works for me as long as I don't need to change the sources (only consume the resulting wasm), which is currently the case. I think if I started contributing tests, it would be less errorpone to have a makefile, but for now all good!

@loganek
Copy link
Collaborator

loganek commented Jan 16, 2023

No problem; just for reference, there's a PR for integrating testsuite with WAMR: bytecodealliance/wasm-micro-runtime#1832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants