Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect min limit of exported memory after grow #1626

Closed
gumb0 opened this issue Mar 5, 2021 · 1 comment
Closed

Incorrect min limit of exported memory after grow #1626

gumb0 opened this issue Mar 5, 2021 · 1 comment

Comments

@gumb0
Copy link
Contributor

gumb0 commented Mar 5, 2021

See this spec test, it passes reference interpreter and it fails on WABT 1.0.21:

../imports.wast:574: error instantiating module: "actual size (1) smaller than declared (2)"
../imports.wast:579: unknown module in register
../imports.wast:580: unknown invoke "$Mgim1.grow"
../imports.wast:580: result length mismatch in assert_return: expected 1, got 0
../imports.wast:581: error instantiating module: "invalid import "grown-imported-memory.memory""
../imports.wast:586: unknown invoke "$Mgim2.size"
../imports.wast:586: result length mismatch in assert_return: expected 1, got 0
@gumb0 gumb0 mentioned this issue Mar 5, 2021
Merged
@keithw
Copy link
Member

keithw commented Sep 18, 2022

This appears to have been fixed in #1738

@keithw keithw closed this as completed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keithw @gumb0