Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note indicating that section ids and section ordering do not correspond #1733

Closed
esoterra opened this issue Feb 23, 2024 · 2 comments
Closed

Comments

@esoterra
Copy link

It is very easy to find the section id table before the grammar for module section layout and assume that they correspond.

The fact that data count appears before code in the binary but has the last section ID is very easy to miss and tooling does not always give intuitive errors.

Recommendation: Add a note right underneath the section ID table saying something like

Note: Section ID does not correspond to section order in the binary. See modules for the ordering.

@rossberg
Copy link
Member

Please see #1734.

@esoterra
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants