Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction should check live DB for existence of account #8

Open
skylerbunny opened this issue Dec 21, 2013 · 0 comments
Open

Correction should check live DB for existence of account #8

skylerbunny opened this issue Dec 21, 2013 · 0 comments

Comments

@skylerbunny
Copy link

It is possible to submit a correction to a Weasyl username, pointing to an account which does not exist.

Steps to reproduce:

  1. Paste in a username to check against, e.g. 'GraemeLion'.
  2. Make a correction to this username, completely nonsensical. 'j3kjkl3jkljflkj3lkjflkjklj'
  3. Click 'Correction'.
  4. SOFT happily creates this bogus entry as a possible account for GraemeLion.

SOFT should check against the database to prevent entries like this from being created. weykent mentions https://github.com/Weasyl/conbadger/blob/master/conbadge.py#L91-L92 as an example of a tool which uses this API endpoint for that purpose.

Doing the above would implicitly fix another potential error which can happen, which is putting entries into the database that are improperly formatted, such as with invalid characters, leading or trailing spaces, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant