New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in the source code when evaluating the constant "r_xyz" #700

Closed

XiangyanAn opened this issue Sep 2, 2024 · 1 comment · Fixed by #701

XiangyanAn commented Sep 2, 2024

I just found that in epoch3d/src/parser/evaluator_blocks.F90, line 300-305, the code reads:

IF (parameters%use_grid_position) THEN
        CALL push_on_eval(&
            SQRT(x(parameters%pack_ix)**2 + y(parameters%pack_iy)**2 &
               + z(parameters%pack_iy)**2))
      ELSE

the index of z might probably be parameters%pack_iz. Otherwise the parser would give a wrong r_xyz.

The text was updated successfully, but these errors were encountered:

TomGoffrey mentioned this issue

Fix parsing of r_xyz #701

Merged

TomGoffrey closed this as completed in #701

Contributor

TomGoffrey commented Sep 6, 2024

@XiangyanAn thanks for bringing this to our attention. This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment