Wrong interpretation of null when setting up action options

[dfdez]

When taking a look to this issue actions/checkout#1378 we have found that the problem was rewarding this action.

Just to give a brief context @bzbarsky-apple was reporting tha sparse-checkout was running when it didn't add any option related to sparse-checkout. And after some digging I figure out that the problem might be related with this line of code.

wretry.action/src/Common.js

Line 134 in b9c799d

if( !( key in options ) && inputs[ key ].default !== undefined )

In the actions/checkout we set sparse-checkout to null but it seems that this default value when evaluated on this action is turning the default value null to "null".

The reason for this is because wretry.action evaluates all the inputs. In the process of creating the default input INPUT_SPARSE_CHECKOUT the env is set to null and when reading from the process.env instead of being a null value is a literal string "null"

wretry.action/src/Common.js

Line 200 in b9c799d

process.env[ key ] = options[ key ];

That is why in this job without setting up sparse-checkout wretry.action is setting up the env INPUT_SPARSE_CHECKOUT=null creating indirectly a default value of sparse-checkout: "null" on the actions/checkout options

[dmvict]

Hello, @dfdez

Here is PR #100 with the fix.

I will notify you when it will be published.

[dmvict]

Hello, @dfdez

The new version is released. Please try v1.2.0 and close the issue if it solves the problem.

[dfdez]

Before v1.2.0:

With v1.2.0:

Working perfect! Nice job! 🥳