New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark that we're intentionally on CT v1. #712

Merged

hayatoito merged 1 commit into WICG:main from jyasskin:ct-v1

Mar 1, 2022

Member

jyasskin commented Feb 17, 2022 •

edited by pr-preview bot

Loading


          Mark that we're intentionally on CT v1.

0012db8

Collaborator

hayatoito commented Feb 18, 2022

Can we have a reviewer for this?
@irori is appropriate?

If this is a minor update for SXG and don't need any intense review, I am happy to do a rubber-stamp.

Member Author

jyasskin commented Feb 18, 2022

This is primarily to fix the build, but it's not the obvious fix after one RFC obsoletes another. I checked with Chrome Security, and it sounds like we don't have a plan to move to v2, so signed exchanges shouldn't either.

Collaborator

hayatoito commented Feb 18, 2022

Ah, I got the context. It seems this is a fix for #704 (or any other build error maybe).
Sorry I didn't notice that.

It sounds the situation is complex than I expected. Anyway, thanks for working on this! Much appreciated.

Member Author

jyasskin commented Feb 18, 2022

It's part of #704: I think the bikeshed bit of the action that's failing there is unnecessary, but I can't be sure while this action is failing.

irori approved these changes

View reviewed changes

Collaborator

irori left a comment

lgtm

hayatoito merged commit b109d94 into WICG:main

Collaborator

hayatoito commented Mar 1, 2022

Let me merge this.
Thanks for working on this!

github-actions bot added a commit that referenced this pull request


          Merge pull request #712 from jyasskin/ct-v1

89a2c77

SHA: b109d94
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot added a commit that referenced this pull request


          Merge pull request #712 from jyasskin/ct-v1

4fa1184

SHA: b109d94
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot added a commit that referenced this pull request


          Merge pull request #712 from jyasskin/ct-v1

0d11e20

SHA: b109d94
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot added a commit that referenced this pull request


          Merge pull request #712 from jyasskin/ct-v1

9d6a5dd

SHA: b109d94
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot added a commit that referenced this pull request


          Merge pull request #712 from jyasskin/ct-v1

b8ba245

SHA: b109d94
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet