Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small order elements in EdDSA #10

Closed
twiss opened this issue Apr 11, 2022 · 0 comments · Fixed by #21
Closed

Small order elements in EdDSA #10

twiss opened this issue Apr 11, 2022 · 0 comments · Fixed by #21

Comments

@twiss
Copy link
Collaborator

twiss commented Apr 11, 2022

The current draft mandates checking for small order elements in X25519 and X448, but not yet in Ed25519 and Ed448. We should probably add this, as per tQsW/webcrypto-curve25519#5, mozilla/standards-positions#271 (comment) and mozilla/standards-positions#271 (comment). I'll try to come up with some text for that.

Another, somewhat orthogonal question, is whether we want to check for this during key import already, rather than during signature verification and key derivation, respectively. This would involve checking the public key against a hardcoded list of known values and rejecting it if it matches. For EdDSA, this would be necessary, anyway - but for key derivation it's slightly more complicated than just checking the derived key. We could add the list of public keys to an appendix of the spec, though, to make this easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant