Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Token types to match privacypass. #256

Open
chris-wood opened this issue May 25, 2023 · 3 comments
Open

Update Token types to match privacypass. #256

chris-wood opened this issue May 25, 2023 · 3 comments

Comments

@chris-wood
Copy link

The PrivateStateTokenV2VOPRF seems to be exactly the type1 tokens as defined in the emerging IETF standard for Privacy Pass. I understand why the PMBToken variant is slightly different, but I'm really struggling to see why we don't have alignment between the VOPRF version for PST and the VOPRF version for Privacy Pass. Is there a technical reason for this divergence? If not, can we please align them?

@dvorak42 dvorak42 changed the title PrivateStateTokenV2VOPRF protocol Update Token types to match privacypass. May 25, 2023
@dvorak42
Copy link
Collaborator

I believe the main divergences are:

  • Token struct (missing token type/challenge_digest)
  • Token verification (using the authenticator value instead of the issuedElement).

@tfpauly
Copy link

tfpauly commented May 25, 2023

Using the standard token struct should be a very obvious change to make--the type is simple to add and useful to denote the type, and the challenge can even be synthesized if needed (other uses of privacy pass already do this).

Using proper token types also allows you to trivially work with both privately and publicly verifiable tokens.

@colinbendell
Copy link

fwiw, I took a stab at trying to enumerate the current spec differences here: https://docs.google.com/document/d/1oYeEI2rv-p5P_say6lBlNIrQjfGCep-a_DD0crAWS-A/edit#heading=h.fers8ov5jl9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants