You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It only had std:blank, which we anticipate being specified as a built-in module that does nothing with no exports.
#164 added std:blank/for-testing in order to test some cases. That's not going to be specified anywhere. But it seemed important to get that coverage.
This architecture is inelegant. Instead, the reference implementation should take a list of built-in modules as an argument to resolve(), and the tests should inject a list appropriate for their testing.
The text was updated successfully, but these errors were encountered:
This is a low-priority code cleanup that I want to just write down while it is fresh in my mind.
Until recently the reference implementation has had a list of built-in modules as a hard-coded list:
import-maps/reference-implementation/lib/resolver.js
Line 5 in da5665c
It only had
std:blank
, which we anticipate being specified as a built-in module that does nothing with no exports.#164 added
std:blank/for-testing
in order to test some cases. That's not going to be specified anywhere. But it seemed important to get that coverage.This architecture is inelegant. Instead, the reference implementation should take a list of built-in modules as an argument to
resolve()
, and the tests should inject a list appropriate for their testing.The text was updated successfully, but these errors were encountered: