Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference implementation cleanup: allow setting the list of built-in modules #165

Closed
domenic opened this issue Jul 22, 2019 · 1 comment
Closed

Comments

@domenic
Copy link
Collaborator

domenic commented Jul 22, 2019

This is a low-priority code cleanup that I want to just write down while it is fresh in my mind.

Until recently the reference implementation has had a list of built-in modules as a hard-coded list:

const supportedBuiltInModules = new Set([`${BUILT_IN_MODULE_SCHEME}:blank`]);

It only had std:blank, which we anticipate being specified as a built-in module that does nothing with no exports.

#164 added std:blank/for-testing in order to test some cases. That's not going to be specified anywhere. But it seemed important to get that coverage.

This architecture is inelegant. Instead, the reference implementation should take a list of built-in modules as an argument to resolve(), and the tests should inject a list appropriate for their testing.

@domenic
Copy link
Collaborator Author

domenic commented Sep 23, 2019

Built-in module support was removed in #176 so this is no longer applicable.

@domenic domenic closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant