Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show logs of skipped only #1

Closed
revelt opened this issue Jun 29, 2021 · 3 comments
Closed

show logs of skipped only #1

revelt opened this issue Jun 29, 2021 · 3 comments

Comments

@revelt
Copy link
Contributor

revelt commented Jun 29, 2021

hi Vladimir! Thank you for this awesome plugin. I noticed the plugin also shows logs in cases where it didn't exclude:

logs

What if we logged only if shouldExcludeFile is true?

console.log(filePath, shouldExcludeFile);

That should reduce the log footprint. What do you think?

@revelt
Copy link
Contributor Author

revelt commented Jun 29, 2021

Or we could maybe format it nicer altogether, to make more informative to user — the boolean is not very clear...

If you approve this feature but you're busy, I can raise a PR. 👍

@VladimirMikulic
Copy link
Owner

Good point @revelt. It should definitely be more clearer. If you have some spare time, feel free to raise a PR and I'll gladly merge it!

@revelt
Copy link
Contributor Author

revelt commented Jun 29, 2021

#3

@revelt revelt closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants