From 9844c93ded8cf3fd6a1c92e3cda21810d902600c Mon Sep 17 00:00:00 2001 From: Bartosz Majsak Date: Fri, 21 Jun 2024 11:51:46 +0200 Subject: [PATCH] chore: removes unused client parameter (#1073) (cherry picked from commit 29937070efcfe001d140a62c7ab06ea270a145b6) --- components/kserve/kserve.go | 2 +- components/kserve/kserve_config_handler.go | 2 +- components/kserve/servicemesh_setup.go | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/components/kserve/kserve.go b/components/kserve/kserve.go index d840284dfa1..e3b2ceffcaf 100644 --- a/components/kserve/kserve.go +++ b/components/kserve/kserve.go @@ -113,7 +113,7 @@ func (k *Kserve) ReconcileComponent(ctx context.Context, cli client.Client, } } else { // Configure dependencies - if err := k.configureServerless(cli, dscispec); err != nil { + if err := k.configureServerless(dscispec); err != nil { return err } if k.DevFlags != nil { diff --git a/components/kserve/kserve_config_handler.go b/components/kserve/kserve_config_handler.go index 6fd4a52e18c..ab0bbba8f6f 100644 --- a/components/kserve/kserve_config_handler.go +++ b/components/kserve/kserve_config_handler.go @@ -117,7 +117,7 @@ func (k *Kserve) setDefaultDeploymentMode(ctx context.Context, cli client.Client return nil } -func (k *Kserve) configureServerless(cli client.Client, instance *dsciv1.DSCInitializationSpec) error { +func (k *Kserve) configureServerless(instance *dsciv1.DSCInitializationSpec) error { switch k.Serving.ManagementState { case operatorv1.Unmanaged: // Bring your own CR fmt.Println("Serverless CR is not configured by the operator, we won't do anything") diff --git a/components/kserve/servicemesh_setup.go b/components/kserve/servicemesh_setup.go index 56fef69a898..e7b7bddf84c 100644 --- a/components/kserve/servicemesh_setup.go +++ b/components/kserve/servicemesh_setup.go @@ -13,10 +13,10 @@ import ( "github.com/opendatahub-io/opendatahub-operator/v2/pkg/feature/servicemesh" ) -func (k *Kserve) configureServiceMesh(c client.Client, dscispec *dsciv1.DSCInitializationSpec) error { +func (k *Kserve) configureServiceMesh(cli client.Client, dscispec *dsciv1.DSCInitializationSpec) error { if dscispec.ServiceMesh != nil { if dscispec.ServiceMesh.ManagementState == operatorv1.Managed && k.GetManagementState() == operatorv1.Managed { - serviceMeshInitializer := feature.ComponentFeaturesHandler(k.GetComponentName(), dscispec, k.defineServiceMeshFeatures(c)) + serviceMeshInitializer := feature.ComponentFeaturesHandler(k.GetComponentName(), dscispec, k.defineServiceMeshFeatures(cli)) return serviceMeshInitializer.Apply() } if dscispec.ServiceMesh.ManagementState == operatorv1.Unmanaged && k.GetManagementState() == operatorv1.Managed { @@ -24,7 +24,7 @@ func (k *Kserve) configureServiceMesh(c client.Client, dscispec *dsciv1.DSCIniti } } - return k.removeServiceMeshConfigurations(c, dscispec) + return k.removeServiceMeshConfigurations(cli, dscispec) } func (k *Kserve) removeServiceMeshConfigurations(cli client.Client, dscispec *dsciv1.DSCInitializationSpec) error {