Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite PDFJS.workerSrc if already set #232

Merged
merged 1 commit into from
Dec 27, 2017

Conversation

bascoder
Copy link
Contributor

If PDFJS.workerSrc isn't overwritten when it's set already, then client code is able to set it to the preferred URL.

Related to issue #162

For instance, my client code can overwrite PDFJS.workerSrc as following:

export class MyComponent implements OnInit {
  ngOnInit() {
    window.PDFJS.workerSrc = '/pdf.worker.min.js';
  }
}

If `PDFJS.workerSrc` isn't overwritten when it's set already, then client code is able to set it to the preferred URL.

Related to issue VadimDez#162
@VadimDez VadimDez merged commit 3bf8b21 into VadimDez:master Dec 27, 2017
@pengisgood
Copy link

It also affected my project, could you please create another release including this change?

@VadimDez VadimDez added this to the 3.0.4 milestone Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants