Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 4 don't work with this library #72

Closed
brasycad opened this issue Mar 29, 2017 · 10 comments
Closed

Update to Angular 4 don't work with this library #72

brasycad opened this issue Mar 29, 2017 · 10 comments

Comments

@brasycad
Copy link

Some days ago, Angular launch new version 4. Its necesary update the library because new compiler error appear.
Thank you in advance

@brasycad brasycad changed the title Update to Angular 4 don't wark Update to Angular 4 don't work with this library Mar 29, 2017
@VadimDez
Copy link
Owner

Just tried myself didn't see any error.
Could you provide steps how to reproduce it?

@brasycad
Copy link
Author

brasycad commented Mar 30, 2017 via email

@brasycad
Copy link
Author

brasycad commented Mar 30, 2017 via email

@VadimDez
Copy link
Owner

VadimDez commented Apr 5, 2017

@brasycad could you tell me - which version of ng2-pdf-viewer are you using ?

@brasycad
Copy link
Author

brasycad commented Apr 6, 2017

Hi vadim.
Version ng2-pdf-viewer@1.0.2, I guess the last..

@CHOUAIAR
Copy link

Hello all,
I'm using Angular 4.0.0 and its working for me the only problem Im having is

Error: Uncaught (in promise): TypeError: Cannot read property 'getDirection' of undefined and its seems like its caused by

document.getElementsByTagName('html')[0].dir = _ui_utils.mozL10n.getDirection();

Kind regards.

@ipoweb
Copy link

ipoweb commented Apr 20, 2017

we have the same problem, we use webpack with angular 4.0

@Irocode
Copy link

Irocode commented Apr 23, 2017

i have the same error:
pdf-viewer.component.js:5Uncaught TypeError: Cannot read property 'prototype' of undefined
at __extends (pdf-viewer.component.js:5)
at pdf-viewer.component.js:10

@janneromell
Copy link

We have a problem that ngAnimate (using Angular 4) stops working after having ng2-pdf-viewer as a dependency. Could it be that the library overwrite another npm package that angular animate is dependent on. Will try to change declared order in package.json to see if that helps.

@VadimDez
Copy link
Owner

Created new release 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants