workbench.colorCustomizations override in main settings.json

[zelphir]

Great work, but after updating to the latest release I've noticed that every time that you switch mode the whole workbench.colorCustomizations in the main settings.json is overridden, that means that if you have custom settings (like me) they are gone!

[jpoon]

@xconverge any ideas?

[xconverge]

Yea, we should read the existing colorCustomizations in configuration.ts at initialization, then we can only change the entries we want if the setting is active and use the stored configuration from configuration.ts

[zelphir]

@xconverge @jpoon any update on that?

[jpoon]

I don't believe either of us are working on it at the moment, but we are happy to take PRs.

[zelphir]

@jpoon what's wrong with saving the settings in the workspace instead of the user settings?

[Chillee]

@zelphir Haha. Funny that you ask.

#1565

You actually posted in there too :)

[zelphir]

@Chillee did you have any chance to take a look at it? I think this setting should stay in the .vscode folder and not in the user settings. Removing the true from this line will fix it (it will move the colors back in the .vscode settings). Or alternatively the modeHandler should be able to update only this block

{
   'statusBar.background': `${color}`,
   'statusBar.noFolderBackground': `${color}`,
   'statusBar.debuggingBackground': `${color}`,
}

Without overriding all the other settings.

[autoferrit]

Any updates on this fix. This issue alone is making it so I can use it as i have many colors customized. Is there a workaround?

[zelphir]

@Chillee Any update on this one?

[jpoon]

Fixed with #2122