Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata values aren't being localised #652

Closed
1 of 3 tasks
mel-mason opened this issue Mar 5, 2019 · 4 comments
Closed
1 of 3 tasks

Metadata values aren't being localised #652

mel-mason opened this issue Mar 5, 2019 · 4 comments

Comments

@mel-mason
Copy link

UV version:

 universalviewer@2.0.2

I'm submitting a:

Current behavior:
With a bilingual english/german manifest and locale set to English the metadata labels are correctly localised to English, but any metadata values with multiple language choices stay in German. I.e. with a manifest containing the metadata block in 'related code' I get the following metadata in the universal.io demo

Date: 1462
Digitization Project: Handschriften aus dem deutschen Sprachraum

Expected behavior:
Metadata values with multiple language choices should be localised to the correct language. I.e. with a manifest containing the metadata block in 'related code' and locale set to English I should get the following metadata

Date: 1462
Digitization Project: Manuscripts from German-Speaking Lands

Steps to reproduce:
Use a manifest with the following top level metadata block in the UV demo (I can't currently give you the full manifest I was using, sorry)

Related code:

"metadata": [
  {
    "label": [
      {
        "@language": "en",
        "@value": "Date"
      },
      {
        "@language": "de",
        "@value": "Datierung"
      }
    ],
    "value": "1462"
  },
  {
    "label": [
      {
        "@language": "de",
        "@value": "Digitalisierungsprojekt"
      },
      {
        "@language": "en",
        "@value": "Digitization Project"
      }
    ],
    "value": [
      {
        "@language": "en",
        "@value": "Manuscripts from German-Speaking Lands"
      },
      {
        "@language": "de",
        "@value": "Handschriften aus dem deutschen Sprachraum"
      }
    ]
  }
]

Other information:

May be an issue with only some of the values having multiple language choices? Although this is permitted in the presentation spec. All of the labels have multiple language choices.

@irv
Copy link
Contributor

irv commented Mar 7, 2019

can confirm this also seems to be the case in UV 3 (and presentation API 3)
example:
https://gist.githubusercontent.com/irv/40f8be0c4bc924b135d11943f6ba92c2/raw/a0b273389444146613e83d066f9504d7e290ad1e/richard.json

@mel-mason
Copy link
Author

Example manifest in presentation API 2: https://iiif.hab.de/object/mss_272-helmst/manifest.json

@LlGC-szw
Copy link

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

@demiankatz
Copy link
Contributor

Cannot reproduce -- I believe this problem has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants