Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-term enzyme miss-cleavage #47

Closed
cpaul32015 opened this issue Jan 6, 2024 · 7 comments
Closed

N-term enzyme miss-cleavage #47

cpaul32015 opened this issue Jan 6, 2024 · 7 comments

Comments

@cpaul32015
Copy link

cpaul32015 commented Jan 6, 2024

No description provided.

@cpaul32015
Copy link
Author

In another case where it seems more like a bug is where I searched with a custom enzyme lysarginase which cleaves N-term to 'K' and 'R', even when I set the allowed MC to 3 I am actually getting peptides up to 5 MC (counting K and R as miss-cleaved sites). Could this issue be something to do with how the algorithm treats proteases cleaves on the N-term to the AA?

20240106_lysarginaseMC_To_CometGitHub

@jke000
Copy link
Collaborator

jke000 commented Jan 6, 2024

Thanks for reporting this. I just spent about 30 minutes looking into this and there is a bug with the logic of counting missed cleavages; at first glance appears to be an issue with N-term enzymes/cleavages. I'll spend time on Monday addressing this and comment more at that time.

@cpaul32015
Copy link
Author

Thank you for the quick response over the weekend! I want to correct about my initial question, turned out I mistakenly counted the cleavage site of AspN to be before 'N' but it should be before 'D', I got that corrected and the MCs for that search made sense now.
The custom lysarginase is still reporting results with 5 MCs when I set to use 3 MCs in the parameter file, it will be great if you can look into it further if it is indeed a bug.

Have a great weekend!

@jke000
Copy link
Collaborator

jke000 commented Jan 8, 2024

Zixiang, I implemented the little fix for this issue but I want to do a few additional tests just to confirm all is well. If you're able to test on your lysarginase dataset, I have patched Comet binaries here that you can download. It would be reassuring to hear that this addresses the issue in your dataset.

@cpaul32015
Copy link
Author

cpaul32015 commented Jan 9, 2024

Hi Jimmy,

Thanks for so quickly addressing the issue, is the current state of Comet search affecting the counting of all N-term enzymes or just the custom ones? From my previous tests it appears that AspN in combination with trypsin worked correctly but the custom lysarginase was having issue.

@cpaul32015 cpaul32015 changed the title Missed cleavage rules for two enzyme search N-term enzyme miss-cleavage Jan 9, 2024
@jke000
Copy link
Collaborator

jke000 commented Jan 9, 2024

The bug affected properly counting all N-term enzyme missed cleavages.

@jke000
Copy link
Collaborator

jke000 commented Jan 11, 2024

I'm going to close this issue which is addressed with commit d7f202b and will be included in the next release, whenever that might be.

@jke000 jke000 closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants